Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion in directory layout #708

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

jesper-friis
Copy link
Collaborator

Description

Fix infinite recursion in directory layout

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19929e3) 71.55% compared to head (6e08328) 71.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
- Coverage   71.55%   71.52%   -0.03%     
==========================================
  Files          16       16              
  Lines        3407     3407              
==========================================
- Hits         2438     2437       -1     
- Misses        969      970       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on codecov, but a new test that actually tests the bug has been added here, so accepted. It is an indirect test and it says that one line is no longer tested. I do not see where this comes from. Maybe you could write and issue on it.

@jesper-friis jesper-friis merged commit b05611c into master Jan 25, 2024
11 of 12 checks passed
@jesper-friis jesper-friis deleted the fix-infinite-recursion-in-directory-layout branch January 25, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants