Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update save recursive and layout #710

Merged
merged 9 commits into from
Jan 26, 2024

Conversation

francescalb
Copy link
Collaborator

Description

Update layout and fix recursive saving of ontology

* save now returns the path to the saved ontology.
  This change does not change the previous usage.
  This is practical when the filename is generated and not given.

* generated layout is updated so that the root is (protocol+domain)
  if there are more of these. Otherwise the generated layout is as before.

* updated test_save to check emmo-structure, recursive saving, also for
  emmo based domain ontologies that import ontologies with various starts of iris

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

* save now returns the path to the saved ontology.
  This change does not change the previous usage.
  This is practical when the filename is generated and not given.

* generated layout is updated so that the root is (protocol+domain)
  if there are more of these. Otherwise the generated layout is as before.

* updated test_save to check emmo-structure, recursive saving, also for
  emmo based domain ontologies that import ontolgoies with various starts of iris
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d59e983) 71.52% compared to head (577931d) 71.74%.

Files Patch % Lines
ontopy/ontology.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   71.52%   71.74%   +0.22%     
==========================================
  Files          16       16              
  Lines        3407     3423      +16     
==========================================
+ Hits         2437     2456      +19     
+ Misses        970      967       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ontopy/ontology.py Outdated Show resolved Hide resolved
tests/test_save.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR 👍

Added a few comments and suggestions.

francescalb and others added 4 commits January 26, 2024 13:48
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
…po/EMMOntoPy into update_save_recursive_and_layout
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed up on two comments

@francescalb francescalb merged commit 1e02982 into master Jan 26, 2024
12 checks passed
@francescalb francescalb deleted the update_save_recursive_and_layout branch January 26, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants