-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update save recursive and layout #710
Conversation
* save now returns the path to the saved ontology. This change does not change the previous usage. This is practical when the filename is generated and not given. * generated layout is updated so that the root is (protocol+domain) if there are more of these. Otherwise the generated layout is as before. * updated test_save to check emmo-structure, recursive saving, also for emmo based domain ontologies that import ontolgoies with various starts of iris
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #710 +/- ##
==========================================
+ Coverage 71.52% 71.74% +0.22%
==========================================
Files 16 16
Lines 3407 3423 +16
==========================================
+ Hits 2437 2456 +19
+ Misses 970 967 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR 👍
Added a few comments and suggestions.
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
…po/EMMOntoPy into update_save_recursive_and_layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed up on two comments
Description
Type of change
Checklist
This checklist can be used as a help for the reviewer.
Comments