Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ontoconvert help #715

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Updated ontoconvert help #715

merged 3 commits into from
Feb 22, 2024

Conversation

jesper-friis
Copy link
Collaborator

Description

Seems that the --base-iri option of ontoconvert is not implemented. Added a note about that in the --help documentation.

This option is used in some EMMO workflows, so we keep it to not break them.

This is a place where we really should have added a "TODO" comment in the code - but pylint doesn't accept that.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7431f3) 71.79% compared to head (dd57c8a) 71.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   71.79%   71.82%   +0.02%     
==========================================
  Files          16       16              
  Lines        3429     3429              
==========================================
+ Hits         2462     2463       +1     
+ Misses        967      966       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -86,13 +86,15 @@ def main(argv: list = None):
action="store_true",
help="Do not infer imported ontologies.",
)
# To be implemented...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# To be implemented...
# To be implemented...Write an issue about it and refer to that issue here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added issue #716

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@francescalb francescalb merged commit 67288ea into master Feb 22, 2024
12 checks passed
@francescalb francescalb deleted the ontoconvert-help branch February 22, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants