Fixed failing test_save in master #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After simplifying paths in test_save_emmo_domain_ontology() in test_save.py to make it possible to debug, the test works again :-)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #756 +/- ##
==========================================
- Coverage 72.14% 72.11% -0.03%
==========================================
Files 17 17
Lines 3486 3486
==========================================
- Hits 2515 2514 -1
- Misses 971 972 +1 ☔ View full report in Codecov by Sentry. |
This was referenced May 1, 2024
francescalb
added a commit
that referenced
this pull request
May 2, 2024
# Description Minor fixes for ontoconvert option help. Also included `emmo:comment` to the set of annotations included in the `--copy-emmo-annotations` option. **Note**: Builds on top of PR #756. Merge that PR first! ## Type of change - [x] Bug fix. - [ ] New feature. - [ ] Documentation update. - [ ] Test update. ## Checklist <!-- Put an `x` in the boxes that apply. You can also fill these out after creating the PR. --> This checklist can be used as a help for the reviewer. - [ ] Is the code easy to read and understand? - [ ] Are comments for humans to read, not computers to disregard? - [ ] Does a new feature has an accompanying new test (in the CI or unit testing schemes)? - [ ] Has the documentation been updated as necessary? - [ ] Does this close the issue? - [ ] Is the change limited to the issue? - [ ] Are errors handled for all outcomes? - [ ] Does the new feature provide new restrictions on dependencies, and if so is this documented? ## Comments <!-- Additional comments here, including clarifications on checklist if applicable. --> --------- Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
francescalb
requested changes
May 2, 2024
This PR is just a simplification without any behavioral changes, so it shouldn't change whether the tests fails or not. Still it made |
francescalb
approved these changes
May 6, 2024
francescalb
added a commit
that referenced
this pull request
May 8, 2024
# Description Minor fixes for ontoconvert option help. Also included `emmo:comment` to the set of annotations included in the `--copy-emmo-annotations` option. **Note**: Builds on top of PR #756. Merge that PR first! ## Type of change - [x] Bug fix. - [ ] New feature. - [ ] Documentation update. - [ ] Test update. ## Checklist <!-- Put an `x` in the boxes that apply. You can also fill these out after creating the PR. --> This checklist can be used as a help for the reviewer. - [ ] Is the code easy to read and understand? - [ ] Are comments for humans to read, not computers to disregard? - [ ] Does a new feature has an accompanying new test (in the CI or unit testing schemes)? - [ ] Has the documentation been updated as necessary? - [ ] Does this close the issue? - [ ] Is the change limited to the issue? - [ ] Are errors handled for all outcomes? - [ ] Does the new feature provide new restrictions on dependencies, and if so is this documented? ## Comments <!-- Additional comments here, including clarifications on checklist if applicable. --> --------- Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifying paths in test_save_emmo_domain_ontology() in test_save.py to make it much easier to debug.