Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Explore Collection Dashboard into Admin options. #747

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

bwatson78
Copy link
Contributor

  • .gitignore: this adds in the new home of the admin YAML.
  • Gemfile.lock and app/controllers/admin/explore_collections_controller.rb: generated by administrate.
  • app/dashboards/explore_collection_dashboard.rb: generated by administrate, but slightly altered:
    • L#30: removed the URLS and replaced them with active, because it's more important for users to see which collections are viewable at a glance.
    • L#68: added a filter active: so that users can get a complete list of collections that will be randomized.
  • app/models/explore_collection.rb: all four text fields are required.
  • app/presenters/explore_collections_presenter.rb and app/views/catalog/_explore_collections.html.erb: changed the previous YAML parsing to the new Model.
  • config/explore_collections.yml: removed because it is no longer used.
  • config/routes.rb: added new admin routes.
  • db/concerns/default_explore_collections.rb: maded this a module because it's helpful in both migration and rspec.
  • db/migrate/20230309172105_create_explore_collections.rb and db/schema.rb: adds table tied to model.
  • db/migrate/20230309212040_stub_default_explore_collections.rb: adds in a default set of 3 collections as a migration.
  • spec/*: tests expectations of new Dashboard.

@bwatson78 bwatson78 requested review from alexBLR and abelemlih March 10, 2023 16:39
@bwatson78 bwatson78 self-assigned this Mar 10, 2023
@bwatson78
Copy link
Contributor Author

Screen Shot 2023-03-10 at 12 40 25 PM
Screen Shot 2023-03-10 at 12 40 36 PM
Screen Shot 2023-03-10 at 12 42 39 PM
Screen Shot 2023-03-10 at 12 42 58 PM

@abelemlih abelemlih merged commit 4605476 into main Mar 10, 2023
@abelemlih abelemlih deleted the adds_admin_explore_collection_dashboard branch March 10, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants