-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not log failed rule insertions in the speedy mode for more vendor-prefixed pseudo-elements/classes #2393
Conversation
…prefixed pseudo-elements/classes
🦋 Changeset detectedLatest commit: b64ae0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I tried to write a unit test for this case, but it seems that JSDOM accepts anything anything ¯_(ツ)_/¯ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b64ae0a:
|
@layershifter could you prepare a codesandbox that would showcase that each of those results in a warning right now? |
@Andarist, sure, here it is https://codesandbox.io/s/pedantic-franklin-31zqw. I used low level APIs there as in our code. Please let me know if it okay or I should make another one. Latest Chrome
Latest Firefox
|
@layershifter thank you! |
What:
This PR expands a fix that was made in #2149 to swallow errors from invalid insertions.
Why:
I added to the list to silence warnings:
-moz-focus-inner
-moz-focusring
-ms-clear
How:
Tested via
yarn lint
/yarn test
& browser.Checklist: