unconditionally use ThemeContext in EmotionElement #2424
Conversation
🦋 Changeset detectedLatest commit: ec4ed43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bc832f2:
|
|
I figure this would be a major given it's a behaviour change that should be tested by dependents? LMK if you want me to change it to a minor or a patch. |
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
|
The tests are kind of boring and specific (I typically don't write tests for the behaviour, as opposed testing behaviour changes in different code paths), but they will prevent someone from accidentally reverting the behaviour or thinking they could optimize back to what it was before. Are they fine or would you like to see something specific tested? |
At the end of the day, this allows more situations to be rendered without crashing and doesn't really impact any situations that were previously rendered OK. So I would just stick with classifying this as a patch bump (a bug fix) |
tills13
force-pushed
the
fix-context-hook-usage
branch
from
e4b23f3 to
bc832f2
Compare
|
@Andarist this is ready to go, I think. |
Fixes: #2423
What: remove conditional use of ThemeContext for serializing styles.
Why: prevents a React error (warning) in the following code: https://codesandbox.io/s/emotion-issue-template-forked-ettgx?file=/src/index.js
Checklist: