Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Theme import for newer Typescript module resolution modes #3101

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

kyvong
Copy link
Contributor

@kyvong kyvong commented Aug 20, 2023

What:
Fix #3092

Why:

How:
Update import statements

Checklist:

  • Documentation NA
  • Tests NA
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2023

🦋 Changeset detected

Latest commit: 4a9602c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4a9602c:

Sandbox Source
Emotion Configuration

@kyvong
Copy link
Contributor Author

kyvong commented Aug 25, 2023

Is there any additional information I could provide to help get this considered for approval? This is a 2 line change in the import statements. This self referencing import is already used in the code, e.g.

import { Theme } from '@emotion/react'

@Andarist
Copy link
Member

I'll try to review your repro case next week.

@bryanph
Copy link

bryanph commented Dec 4, 2023

@Andarist Any chance this can be merged soon?

@kyvong
Copy link
Contributor Author

kyvong commented Dec 23, 2023

@emmatown maybe you could help review this since it looks like you worked on similar issues with "bundler" module resolution before. It is only a 2 line change.

@emmatown emmatown merged commit 49c20b4 into emotion-js:main Dec 23, 2023
14 checks passed
@github-actions github-actions bot mentioned this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript typing issue with themes when using "Bundler" module resolution
4 participants