-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hasOwnProperty from utils #3159
Conversation
🦋 Changeset detectedLatest commit: 0d991fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is fixing something this PR should have a test case included to prevent future regressions. If the test is too hard to setup then at the very least we should get cloneable repository that would reproduce the fixed issue.
Exported hasOwnProperty conflicts with exports.prototype.hasOwnProperty. Because it tries to override itself.
To support old targets
262c894
to
0d991fd
Compare
'@emotion/react': patch | ||
--- | ||
|
||
Remove hasOwnProperty from utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed an internal hasOwnProperty
to hasOwn
. This avoids problems in CommonJS environments when the consumer tries to prevent prototype pollution with Object.freeze(Object.prototype)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh, this was meant to be a code suggestion and not a regular comment 😅
What:
Exported hasOwnProperty conflicts with exports.prototype.hasOwnProperty.
Why:
Because it tries to override itself.
How:
Checklist: