Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hasOwnProperty from utils #3159

Merged
merged 12 commits into from
Feb 27, 2024

Conversation

iegik
Copy link
Contributor

@iegik iegik commented Feb 27, 2024

What:

Exported hasOwnProperty conflicts with exports.prototype.hasOwnProperty.

Why:

Because it tries to override itself.

How:

Checklist:

  • Documentation
  • Tests
  • Code complete
  • Changeset

Copy link

changeset-bot bot commented Feb 27, 2024

🦋 Changeset detected

Latest commit: 0d991fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Feb 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.07%. Comparing base (0bfa978) to head (262c894).

❗ Current head 262c894 differs from pull request most recent head 0d991fd. Consider uploading reports for the commit 0d991fd to get more accurate results

Additional details and impacted files
Files Coverage Δ
packages/react/src/emotion-element.js 100.00% <100.00%> (ø)
packages/react/src/jsx-dev-runtime.js 100.00% <100.00%> (ø)
packages/react/src/jsx.js 100.00% <100.00%> (ø)
packages/react/src/utils.js 100.00% <100.00%> (ø)
packages/react/src/jsx-runtime.js 55.55% <50.00%> (ø)

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is fixing something this PR should have a test case included to prevent future regressions. If the test is too hard to setup then at the very least we should get cloneable repository that would reproduce the fixed issue.

@iegik iegik force-pushed the fix/3158-hasOwnProperty branch from 262c894 to 0d991fd Compare February 27, 2024 12:52
'@emotion/react': patch
---

Remove hasOwnProperty from utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed an internal hasOwnProperty to hasOwn. This avoids problems in CommonJS environments when the consumer tries to prevent prototype pollution with Object.freeze(Object.prototype).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, this was meant to be a code suggestion and not a regular comment 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants