fix(cli): allow multiple occurrences of the same name in user properties

[Red-Asuka]

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #123

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

[ysfscream]

else is needless after the return statement.

if (!previous) return { [key]: value }
if (xxx) {
    xxxx
}

[Red-Asuka]

I know that else is unnecessary, but I think that in some cases else can make the code clearer. This is the code without else, what do you think?

    if (!previous) return { [key]: val }
    if (previous[key]) {
      if (Array.isArray(previous[key])) {
        ;(previous[key] as string[]).push(val)
      } else {
        previous[key] = [previous[key] as string, val]
      }
      return previous
    } else {
      return { ...previous, [key]: val }
    }

[Red-Asuka]

The final code:

    if (!previous) return { [key]: val }
    if (previous[key]) {
      if (Array.isArray(previous[key])) {
        const currentVal = previous[key] as string[]
        currentVal.push(val)
        return { ...previous, [key]: currentVal }
      }
      previous[key] = [previous[key] as string, val]
      return previous
    }
    return { ...previous, [key]: val }

[Red-Asuka]

Or

    if (!previous) return { [key]: val }
    if (!previous[key]) return { ...previous, [key]: val }
    if (Array.isArray(previous[key])) {
      const currentVal = previous[key] as string[]
      currentVal.push(val)
      return { ...previous, [key]: currentVal }
    }
    previous[key] = [previous[key] as string, val]
    return previous

[ysfscream]

else needs continuity, and return means execution is over. It doesn't say here that else doesn't need to be used, I think this code is just fine

if (!previous) return { [key]: val }
if (previous[key]) {
  if (Array.isArray(previous[key])) {
	const currentVal = previous[key] as string[]
     currentVal.push(val)
  } else {
  	const currentVal = previous[key] as string
    previous[key] = [currentVal, val]
  }
  return previous
}
 return { ...previous, [key]: val }

[ysfscream]

Anyway, I will merge first. But the principle of my judgment is that if there is a return in the if, there will be no need for else; if not, then there is a need for else; this proposal should be in the rules of Eslint also had, personal preference, code readability is our goal.

[ysfscream]

It's a nice job.

[ysfscream]

Please declare an internal variable to represent previous[key], For example:

const objValues = previous[key] as string[]

Looks cumbersome, but more clear type