fix(connections): improve connection handling when set selected conne… #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysfscream
added
enhancement
Red-Asuka
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ction
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
Cannot select default connection when navigating Connect → other pages → New → Connect.
Issue Number
Example: #123
What is the new behavior?
In this PR, we have made the following changes:
Removed unused constants
TOGGLE_AUTO_SCROLLandSET_AUTO_SCROLL_INTERVAL.Updated the loadDetail method in the Connections component to only set the current connection ID if it's not new.
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information