You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for the PR upgrading faker.js to v8. Before I decide on merging, I have a few questions:
Reason for the Upgrade: Could you elaborate on the motivations behind upgrading from v7 to v8? While newer versions often come with performance improvements, new features, or enhanced security, I'd like to understand the specific advantages or problems this resolves.
Breaking Change: You mentioned that this PR introduces a breaking change. Could you specify what aspects might be affected and what changes our current users need to make?
Testing: Have you been able to test whether the scripts from our users work as expected after this upgrade? I want to ensure that this change is okay with them. It would be appreciated if you have test results or scenarios to share.
Thank you for your contribution! I'm looking forward to your response so I can move forward with this PR more efficiently.
choreChanges in build tools or dependent packagesCLIMQTTX CLIdependenciesPull requests that update a dependency file
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ysfscream
added
dependencies
https://fakerjs.dev/guide/upgrading.html#deprecations-and-other-changes
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
faker v7 used
Issue Number
none
What is the new behavior?
faker v8 used
Does this PR introduce a breaking change?
Specific Instructions
none
Other information
none