Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add message limit option to simulate command #1600

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

Red-Asuka
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

The "simulate" command cannot limit the total number of messages sent.

Issue Number

#1597

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@Red-Asuka Red-Asuka added feature This pr is a feature CLI MQTTX CLI labels Mar 5, 2024
@Red-Asuka Red-Asuka added this to the v1.9.10 milestone Mar 5, 2024
@Red-Asuka Red-Asuka self-assigned this Mar 5, 2024
@ysfscream
Copy link
Member

BTW, remember to update the documentation to a draft before releasing the next version.

@ysfscream ysfscream merged commit 364a39e into main Mar 5, 2024
5 checks passed
@ysfscream ysfscream deleted the lyd/dev branch March 5, 2024 02:42
@Red-Asuka
Copy link
Member Author

@ysfscream The document Simulate section has instructions and does not need to be updated.

It has basically the same as the Publish Benchmark command options, the following will only list the new or changed options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI MQTTX CLI feature This pr is a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants