Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desktop): add save button for new & edit connection #1610

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

XL-YiBai
Copy link
Contributor

@XL-YiBai XL-YiBai commented Mar 23, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

When you want to make a new connection and fill in some (but not necessarly all) fields you can't temporailty save it and complement it later on. You can only choose Connect which is not always what you want. The same goes for editing connections.

Issue Number

#735

What is the new behavior?

When creating or editing connection information, the current information can be saved. Instead of clicking the Connect button to establish a connection.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

屏幕录制2024-03-25 10 19 26

@XL-YiBai XL-YiBai self-assigned this Mar 23, 2024
@XL-YiBai XL-YiBai added desktop MQTTX Desktop feature This pr is a feature enhancement New feature or request labels Mar 23, 2024
@ysfscream ysfscream added this to the v1.9.10 milestone Mar 25, 2024
@Red-Asuka
Copy link
Member

@XL-YiBai Can you provide a screenshot after the modification?

@Red-Asuka
Copy link
Member

Looking good, can we also add this feature to the MQTTX Web?

@XL-YiBai
Copy link
Contributor Author

XL-YiBai commented Mar 25, 2024

@XL-YiBai Can you provide a screenshot after the modification?

I just uploaded a demonstration video. 😆
Create a new connection also has the same effect.

@XL-YiBai
Copy link
Contributor Author

Looking good, can we also add this feature to the MQTTX Web?

Of course, I will complete it in my free time.

@ysfscream
Copy link
Member

@XL-YiBai

Thank you for your contribution; it indeed looks like a valuable enhancement. However, for MQTTX, modifying parameters and saving without immediate connection isn't a frequent operation. Thus, we propose integrating this functionality via a dropdown menu to maintain a cleaner interface. Specifically, we can have the "Connect" button for standard operations on the left, and a dropdown menu on the right with an option for "Save Only". This approach benefits us by:

  1. Keeping the UI Clean: Reducing button clutter for a more focused user experience.
  2. Intuitive Functionality: The dropdown menu clearly indicates additional actions without overwhelming the main interface.
  3. Streamlining Common Processes: Ensures a smooth flow for the most common action—connecting—while offering flexibility for different user needs.

Resources:

https://element-plus.org/zh-CN/component/dropdown.html

image

the Right icon:

image

the UI design:

image

@XL-YiBai
Copy link
Contributor Author

@ysfscream Thank you for your valuable suggestion and detailed design proposal. I will incorporate the suggested changes into the code.

@XL-YiBai XL-YiBai force-pushed the my/main branch 2 times, most recently from 329a927 to a798e26 Compare March 25, 2024 16:17
@XL-YiBai XL-YiBai added the web MQTTX Web label Mar 26, 2024
@XL-YiBai
Copy link
Contributor Author

image

@XL-YiBai XL-YiBai marked this pull request as ready for review March 26, 2024 01:17
@ysfscream
Copy link
Member

@ni00, welcome to review this PR. Perhaps you could provide some more useful suggestions. 😄

src/lang/common.ts Show resolved Hide resolved
Copy link
Member

@ysfscream ysfscream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@ysfscream ysfscream merged commit 3fdea8c into emqx:main Mar 27, 2024
3 checks passed
@XL-YiBai XL-YiBai deleted the my/main branch March 27, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature web MQTTX Web
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants