Skip to content

Commit

Permalink
Only skip emscripten_log test on SpiderMonkey in asm.js modes, since …
Browse files Browse the repository at this point in the history
…the test fails due to asm.js execution in SpiderMonkey not being able to retrieve callstacks. Add link to relevant bugzilla entry. Closes #1970.
  • Loading branch information
juj committed Feb 1, 2014
1 parent 53af8ab commit f5c957b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -6166,7 +6166,9 @@ def post(filename):
self.build(src, dirname, os.path.join(dirname, 'src.cpp'), post_build=(None, post))

def test_emscripten_log(self):
self.banned_js_engines = [SPIDERMONKEY_ENGINE] # XXX, emscripten_log is broken in spidermonkey currently, issue #1970
if Settings.ASM_JS:
# XXX Does not work in SpiderMonkey since callstacks cannot be captured when running in asm.js, see https://bugzilla.mozilla.org/show_bug.cgi?id=947996
self.banned_js_engines = [SPIDERMONKEY_ENGINE]
if self.emcc_args is None: return self.skip('This test needs libc.')
if '-g' not in Building.COMPILER_TEST_OPTS: Building.COMPILER_TEST_OPTS.append('-g')
self.do_run('#define RUN_FROM_JS_SHELL\n' + open(path_from_root('tests', 'emscripten_log', 'emscripten_log.cpp')).read(), "Success!")
Expand Down

0 comments on commit f5c957b

Please sign in to comment.