-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add implicit wasm feature disabling based on min browser versions
With https://reviews.llvm.org/D125728 about to land in LLVM we have four features which will be enabled by default. In order to allow users to continue to target older browsers we want to turn these features off by default when users opt into older browser support. As part of this change we are bumping the default minimum browser versions for Safari and Firefox to the minimum version needed to supported these 4 features which are about to be enabled by default: - firefix: 65 -> 79 - safari: 12 - 15
- Loading branch information
Showing
4 changed files
with
79 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
import logging | ||
from enum import IntEnum, auto | ||
|
||
from .settings import settings | ||
|
||
logger = logging.getLogger('feature_matrix') | ||
|
||
|
||
class Feature(IntEnum): | ||
NON_TRAPPING_FPTOINT = auto() | ||
SIGN_EXT = auto() | ||
BULK_MEMORY = auto() | ||
MUTABLE_GLOBALS = auto() | ||
|
||
|
||
min_browser_versions = { | ||
Feature.NON_TRAPPING_FPTOINT: { | ||
'chrome': 75, | ||
'firefox': 65, | ||
'safari': 150000, | ||
}, | ||
Feature.SIGN_EXT: { | ||
'chrome': 74, | ||
'firefox': 62, | ||
'safari': 141000, | ||
}, | ||
Feature.BULK_MEMORY: { | ||
'chrome': 75, | ||
'firefox': 79, | ||
'safari': 150000, | ||
}, | ||
Feature.MUTABLE_GLOBALS: { | ||
'chrome': 74, | ||
'firefox': -1, # Firefox has always supported mutable globals apparently | ||
'safari': 120000, | ||
}, | ||
} | ||
|
||
|
||
def caniuse(feature): | ||
min_versions = min_browser_versions[feature] | ||
if settings.MIN_CHROME_VERSION < min_versions['chrome']: | ||
return False | ||
if settings.MIN_FIREFOX_VERSION < min_versions['firefox']: | ||
return False | ||
if settings.MIN_SAFARI_VERSION < min_versions['safari']: | ||
return False | ||
return True | ||
|
||
|
||
def get_feature_flags(): | ||
flags = [] | ||
|
||
if not caniuse(Feature.NON_TRAPPING_FPTOINT): | ||
logger.debug('adding -mno-nontrapping-fptoint due to target browser selection') | ||
flags.append('-mno-nontrapping-fptoint') | ||
|
||
if not caniuse(Feature.SIGN_EXT): | ||
logger.debug('adding -mnosign-ext due to target browser selection') | ||
flags.append('-mno-sign-ext') | ||
|
||
if not caniuse(Feature.BULK_MEMORY): | ||
logger.debug('adding -mnobulk-memory due to target browser selection') | ||
flags.append('-mno-bulk-memory') | ||
|
||
if not caniuse(Feature.MUTABLE_GLOBALS): | ||
logger.debug('adding -mnomutable-globals due to target browser selection') | ||
flags.append('-mno-mutable-globals') | ||
|
||
return flags |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters