Add IGNORE_MISSING_MAIN setting and --no-entry argument #10827
Conversation
sbc100
force-pushed
the
no_entry
branch
4 times, most recently
from
92a2cea
to
6a9aa23
Compare
sbc100
changed the title
This setting == |
|
Sorry, I renamed the setting and it inverted it meaning. |
tools/shared.py
Outdated
| if not use_start_function: | ||
| cmd += ['--no-entry'] | ||
| has_main = '_main' in Settings.EXPORTED_FUNCTIONS |
There was a problem hiding this comment.
instead of has, how about exports?
src/settings.js
Outdated
| // * AUTO_JS_LIBRARIES is disabled. | ||
| // * AUTO_ARCHIVE_INDEXES is disabled. | ||
| // [compile+link] | ||
| var STRICT = 0; | ||
|
|
||
| // Allow program to link with or without `main` symbol. | ||
| // If this is disabled then one must provide a `main` symbol or expclictly |
|
The idea with having it behind and option is that is that we can introduce it gradually and back it out if people object. Since its technically a breaking change. It also allows me to enable it unconditionally in places like STRICT and with LLD_REPORT_UNDEFINED which it turns out needs this feature. I'd love to get rid of the option ASAP and just have it be the default. In fact I think I can make this an internal option so no user should ever be exposed to it. |
|
I see, thanks, sgtm. And lgtm with those comments. |
This settings, when enabled, forces the developer to be explicit about the presence or absence of `main` their program. It is disabled by default but enabled in STRICT mode. In this mode, if you want to build a program without a `main` function you must either build with `--no-entry` or pass a list of EXPORTED_FUNCTIONS the doesn't include `_main`. The reason for adding the extra `--no-entry` option is that this is what `wasm-ld` recommends in its corresponding error message. Its also a lot easier to type than `-s EXPORTED_FUNCTIONS=[]`. This change is a step towards enabling better error reporting from lld by enabling the removal of the `--allow-undefined` option.
This setting, wen disabled, forces they developer to be explicit
about the presence of absence of main their program. It is enabled
by default but disabled in STRICT mode.
When disabled, if you want to build a program without an main function
one must either build with
--no-entryor pass a list ofEXPORTED_FUNCTIONS the doesn't include
_main.The reason for adding the extra
--no-entrymethod is that thisis what wasm-ld recommends in its corresponding error message. Its
also a lot easier to type than
-s EXPORTED_FUNCTIONS=[].This change is a step towards enabling better error reporting from lld
by enabling the removal of the
--allow-undefinedoption. See #10826Partia fix for: #9640