Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example of using externref in assembly code #15913

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Add example of using externref in assembly code #15913

merged 1 commit into from
Jan 7, 2022

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jan 7, 2022

See #15878

@sbc100 sbc100 requested a review from kripken January 7, 2022 14:36
kripken
kripken reviewed Jan 7, 2022
View reviewed changes
tests/test_core.py Outdated Show resolved Hide resolved
@sbc100 sbc100 enabled auto-merge (squash) January 7, 2022 16:06
kripken
kripken approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that this works so easily!

I wonder if maybe we should add something pointing to this test in the docs? Or maybe it's too early.

@sbc100
Copy link
Collaborator Author

sbc100 commented Jan 7, 2022

Nice that this works so easily!

I wonder if maybe we should add something pointing to this test in the docs? Or maybe it's too early.

Perhaps as a followup.

I'm a little worried that we might still want to make changes to the .s format, so we might not want to be advertising it too loudly... although its been stable for a long time now.

@sbc100 sbc100 merged commit 8988358 into main Jan 7, 2022
@sbc100 sbc100 deleted the externref_example branch January 7, 2022 17:49
@sbc100 sbc100 mentioned this pull request Jan 10, 2022
Closed
@codefromthecrypt codefromthecrypt mentioned this pull request May 12, 2022
Closed
@Thaina
Copy link

Thaina commented Mar 18, 2023

As it seem LLVM introduce support for externref in c,

https://github.com/llvm/llvm-project/blob/main/clang/test/CodeGen/WebAssembly/wasm-externref.c

Can we have example to use externref in c too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbc100 @Thaina @kripken