Process --pre-js and --post-js files in jsifier.js #18525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
pre_post_js
branch
5 times, most recently
from
534e277 to
9f96cea
Compare
sbc100
force-pushed
the
pre_post_js
branch
2 times, most recently
from
a62fc36 to
11de551
Compare
|
LGTM, this sounds like a good unification. |
This teats pre and post JS files more like normal runtime and library files which simplifies the code and avoids the special case processing in emcc.py. This also means that pre and post JS also now go through macro preprocessor which should be useful in some cases.
sbc100
added a commit
that referenced
this pull request
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This treats pre and post JS files more like normal runtime and library files which simplifies the code and avoids the special case processing in emcc.py.
This also means that pre and post JS also now go through macro preprocessor which should be useful in some cases.