Update flags for getting exception messages in docs #18538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewtex
force-pushed
the
exception-message-flags
branch
from
e203d60 to
86b60c9
Compare
sbc100
reviewed
Jan 16, 2023
| @@ -170,7 +170,7 @@ returns the ``what`` function call result. | |||
| emscripten::function("getExceptionMessage", &getExceptionMessage); | |||
| }; | |||
|
|
|||
| This requires using the linker flag ``--bind``. | |||
| This requires using the linker flags ``-l embind -s EXPORT_EXCEPTION_HANDLING_HELPERS=1``. | |||
There was a problem hiding this comment.
Just -sEXPORT_EXCEPTION_HANDLING_HELPERS (no space or =1 needed)
sbc100
approved these changes
Jan 16, 2023
thewtex
force-pushed
the
exception-message-flags
branch
from
86b60c9 to
c098684
Compare
sbc100
reviewed
Jan 16, 2023
`-l embind` is now preferred over `--bind`. Add `-s EXPORT_EXCEPTION_HANDLING_HELPERS` to export the required symbols, which are now multiple and can vary based on exception handling backend.
thewtex
force-pushed
the
exception-message-flags
branch
from
c098684 to
b4b9c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-l embindis now preferred over--bind.Add
-s EXPORT_EXCEPTION_HANDLING_HELPERSto export the required symbols, which are now multiple and can vary based on exception handling backend.