Update terser to v5.18.2 and verify optional chaining support #19805
+30,976
−21,640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
update_terser_again
branch
from
7e004c8 to
08e2361
Compare
kripken
reviewed
Jul 7, 2023
| @@ -275,4 +275,4 @@ WebAssembly.instantiate(Module["wasm"], imports).then(output => { | |||
| dynCall_iiii = asm["p"]; | |||
| initRuntime(asm); | |||
| ready(); | |||
| }); | |||
| })); | |||
There was a problem hiding this comment.
They are not needed, but its seems like acorn is producing them now.. I guess its just a slight behaviour change.
As you can see, no actual code size tests regressed so I guess closure is able just erase these.
If we care we would need to investigate why acorn started doing this.. and see if we can disable it.
There was a problem hiding this comment.
Do you think we care about these braces?
There was a problem hiding this comment.
Yeah, I guess closure fixes this up. Odd terser slightly regressed here but probably this is related to some bugfix for them...
kripken
approved these changes
Jul 7, 2023
sbc100
added a commit
that referenced
this pull request
Jul 7, 2023
sbc100
added a commit
that referenced
this pull request
Jul 7, 2023
sbc100
added a commit
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15827