Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Chrome Unstable with new Headless mode #20069

Merged
merged 10 commits into from
Sep 14, 2023
Merged

Switch to Chrome Unstable with new Headless mode #20069

merged 10 commits into from
Sep 14, 2023

Conversation

kripken
Copy link
Member

@kripken kripken commented Aug 18, 2023

After Chrome updated, we can now use unstable/dev with new headless mode and all
tests pass once more.

Previously a Chrome update caused beta to fail with either old or new headless.

@kripken
Copy link
Member Author

kripken commented Aug 18, 2023

I spent time trying to understand Beta's GL crashes, but I can't reproduce them locally no matter how hard I try. It seems like using swiftshader should mean we don't depend on GPU hardware, but there is still some difference that I can't pin down. Anyhow, though, it is fixed in Dev, so it seems moot.

Note that Dev also has some issue with emrun. My best guess there is something to do with the lockfile used to ensure a single instance. I saw errors on that sometimes, and deleting the file helped. emrun kills the chrome process, so that might be causing a bad lockfile situation.

@kripken kripken requested a review from sbc100 September 14, 2023 17:54
@kripken kripken marked this pull request as ready for review September 14, 2023 17:54
@kripken kripken changed the title Show that Chrome Dev passes GL tests with headless=new [Do not land] Switch to Chrome Dev with new Headless mode Sep 14, 2023
@kripken
Copy link
Member Author

kripken commented Sep 14, 2023

This PR now switches us to Chrome unstable, with new headless, which seems to pass tests (all but emrun, which was disabled before).

@kripken kripken changed the title Switch to Chrome Dev with new Headless mode Switch to Chrome Unstable with new Headless mode Sep 14, 2023
# current beta.
wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
# wget -O ~/chrome.deb https://storage.googleapis.com/webassembly/chrome/google-chrome-stable_current_amd64.deb
wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-unstable_current_amd64.deb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "unstable"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "unstable" and "beta" refer to the same thing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not uncomment line 45 instead then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that's wrong. Unstable==dev.

@sbc100
Copy link
Collaborator

sbc100 commented Sep 14, 2023

Can you update the PR description?

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comment

@kripken kripken enabled auto-merge (squash) September 14, 2023 19:28
@kripken kripken merged commit a5e0710 into main Sep 14, 2023
@kripken kripken deleted the debug.5 branch September 14, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants