-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Chrome Unstable with new Headless mode #20069
Conversation
I spent time trying to understand Beta's GL crashes, but I can't reproduce them locally no matter how hard I try. It seems like using swiftshader should mean we don't depend on GPU hardware, but there is still some difference that I can't pin down. Anyhow, though, it is fixed in Dev, so it seems moot. Note that Dev also has some issue with emrun. My best guess there is something to do with the lockfile used to ensure a single instance. I saw errors on that sometimes, and deleting the file helped. emrun kills the chrome process, so that might be causing a bad lockfile situation. |
This PR now switches us to Chrome unstable, with new headless, which seems to pass tests (all but emrun, which was disabled before). |
# current beta. | ||
wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb | ||
# wget -O ~/chrome.deb https://storage.googleapis.com/webassembly/chrome/google-chrome-stable_current_amd64.deb | ||
wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-unstable_current_amd64.deb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "unstable"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "unstable" and "beta" refer to the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not uncomment line 45 instead then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, that's wrong. Unstable==dev.
Can you update the PR description? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % comment
After Chrome updated, we can now use unstable/dev with new headless mode and all
tests pass once more.
Previously a Chrome update caused beta to fail with either old or new headless.