Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Consistently capitalize Wasm when referring to it in the docs. NFC #20266

Merged
merged 2 commits into from
Sep 18, 2023
Merged

[docs] Consistently capitalize Wasm when referring to it in the docs. NFC #20266

merged 2 commits into from
Sep 18, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 15, 2023 •
edited
Loading

Also remove a few referenses to fastcomp and/or "upstream" backends.

@sbc100 sbc100 requested a review from dschuff September 15, 2023 20:26
dschuff
dschuff approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I don't have a lot of hope that we will remember to keep capitalizing Wasm consistently, nor would it be a disaster if we don't (as long as we don't use WASM anywhere😂)

site/source/docs/site/glossary.rst Outdated Show resolved Hide resolved
@sbc100 @dschuff
Update site/source/docs/site/glossary.rst
6bcd138 
Co-authored-by: Derek Schuff <dschuff@chromium.org>
@sbc100 sbc100 merged commit e99f39c into main Sep 18, 2023
1 of 2 checks passed
@sbc100 sbc100 deleted the wasm_capitalization branch September 18, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschuff dschuff dschuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @dschuff