Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a two different fixes here, neither of which are needed except in the nightly version of chrome.
instantiateWasm
override used in audio worklets return the result ofreceiveInstance
rather then directly returning the wasm exports. This means that the resulting object has the needed wrappers applied. This was causing an exception even on older version of chrome, but the tests still passed regardless. With newer versions of chrome the exception seems to cause the worklet creation to fail. (see Ensure exports are correctly handled when instantiateWasm is present #18711)toIndexType
here but that doesn't work inaudio_worklet.js
.