Add a stub for _Unwind_RaiseException #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _Unwind_RaiseException: function(ex) { | ||
| abort('Unwind_RaiseException'); |
There was a problem hiding this comment.
could this just call cxa_throw?
There was a problem hiding this comment.
Probably yes, but cxa_throw takes three parameters and I'm not familiar enough with emscripten to know how to extract the relevant values from ex.
There was a problem hiding this comment.
seems like you can call cxa_throw(ex, null, null).
|
Also need a test for landing. |
|
Oh I was expecting to get away with it without a test :-/ |
|
Sorry, yeah, we do need tests for stuff like this, or else we have no guarantee it won't break. Let me know if you need any help writing one. |
|
Might as well add a test later when things are further along. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a basic implementation to make Rust happy.
This is the code I used to pass the tests. It's obviously not clean, but it's still better than aborting.
If I have some time I'll try figure out correctly how exceptions handling works in C++ and emscripten and write some correct code.