fix_renderViaOffscreenBackBuffer_init_and_creation_test #6986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juj
force-pushed
the
fix_renderViaOffscreenBackBuffer_init_and_creation_test
branch
from
a744c8b to
ace6b09
Compare
kripken
approved these changes
Aug 13, 2018
src/library_gl.js
Outdated
| Module.printErr('renderViaOffscreenBackBuffer=true specified in WebGL context creation attributes, pass linker flag -s OFFSCREEN_FRAMEBUFFER=1 to enable support!'); | ||
| #endif | ||
| return 0; | ||
| if (webGLContextAttributes['renderViaOffscreenBackBuffer']) Module.printErr('renderViaOffscreenBackBuffer=true specified in WebGL context creation attributes, pass linker flag -s OFFSCREEN_FRAMEBUFFER=1 to enable support!'); |
There was a problem hiding this comment.
Module.printErr( should be err(
| #if GL_DEBUG | ||
| Module.printErr('renderViaOffscreenBackBuffer=true specified in WebGL context creation attributes, pass linker flag -s OFFSCREEN_FRAMEBUFFER=1 to enable support!'); | ||
| #endif | ||
| return 0; |
There was a problem hiding this comment.
was the removal of the return 0 intentional? (so now it will warn and continue? sounds ok to me)
There was a problem hiding this comment.
yes, removed that because I don't want to afford to make this check in non-OFFSCREEN_FRAMEBUFFER builds. Then, the return 0; behavior would only be present if GL_DEBUG is set, but that does not feel good - one doesn't want to change runtime behavior depending on a debug flag - so best is to demote the print to a debug time warning only.
juj
force-pushed
the
fix_renderViaOffscreenBackBuffer_init_and_creation_test
branch
from
ace6b09 to
39eb98a
Compare
… behind GL_DEBUG for 'do not pay for what you do not use', and add missing initialization of renderViaOffscreenBackBuffer field.
juj
force-pushed
the
fix_renderViaOffscreenBackBuffer_init_and_creation_test
branch
from
39eb98a to
fa20d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move renderViaOffscreenBackBuffer/OFFSCREEN_FRAMEBUFFER enabling test behind GL_DEBUG for 'do not pay for what you do not use', and add missing initialization of renderViaOffscreenBackBuffer field.