bugfix: move pin to group action was rejected if only 1 pin in target…

… group
emsec · Jun 5, 2023 · 591d2d1 · 591d2d1
1 parent 99e1256
commit 591d2d1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/plugins/gui/include/gui/selection_details_widget/selection_details_widget.h b/plugins/gui/include/gui/selection_details_widget/selection_details_widget.h
@@ -40,9 +40,6 @@ namespace hal
     class Grouping;
     class Searchbar;
     class SelectionTreeView;
-    class ModuleDetailsWidget;
-    class GateDetailsWidget;
-    class NetDetailsWidget;
     class UserAction;
     class UserActionObject;
     class SettingsItemCheckbox;
@@ -344,9 +341,6 @@ namespace hal
 
         QStackedWidget* mStackedWidget;
 
-        GateDetailsWidget* mGateDetails;
-        NetDetailsWidget* mNetDetails;
-        ModuleDetailsWidget* mModuleDetails;
         QLabel* mItemDeletedLabel;
         QLabel* mNoSelectionLabel;
 

diff --git a/plugins/gui/src/user_action/action_reorder_object.cpp b/plugins/gui/src/user_action/action_reorder_object.cpp
@@ -38,13 +38,16 @@ namespace hal
                     return false;
                 }
                 auto pinGroup = pin->get_group().first;
-                if (pinGroup && pinGroup->size() > 1)
+                if (pinGroup)
                 {
-                    oldIndex = pin->get_group().second;
-                    auto result   = mod->move_pin_within_group(pinGroup, pin, mNewIndex);
-                    if (result.is_error())
+                    if (pinGroup->size() > 1)
                     {
-                        return false;
+                        oldIndex = pin->get_group().second;
+                        auto result   = mod->move_pin_within_group(pinGroup, pin, mNewIndex);
+                        if (result.is_error())
+                        {
+                            return false;
+                        }
                     }
                 }
                 else