Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Shower Duration to MQTT Discovery topic #1267

Closed
proddy opened this issue Aug 26, 2023 · 5 comments
Closed

Add Shower Duration to MQTT Discovery topic #1267

proddy opened this issue Aug 26, 2023 · 5 comments
Assignees
@proddy
Labels
enhancement New feature or request
Milestone
v3.6.0

Comments

@proddy
Copy link
Contributor

proddy commented Aug 26, 2023 •
edited
Loading

Add the shower_duration as an MQTT topic which makes it easier to add as an HA entity

(from the discussion #1248)
@proddy proddy added the enhancement New feature or request label Aug 26, 2023
@proddy proddy added this to the v3.7.0 milestone Aug 26, 2023
@proddy proddy self-assigned this Aug 26, 2023
proddy added a commit to emsesp/docs that referenced this issue Aug 29, 2023
@proddy
Update HA shower emsesp/EMS-ESP32#1267
e9ede9a
proddy added a commit to proddy/EMS-ESP32 that referenced this issue Aug 29, 2023
@proddy
API call for shower coldshot - emsesp#1267
f46b002
@proddy
Copy link
Contributor Author

proddy commented Aug 29, 2023

See https://emsesp.github.io/docs/Home-Assistant/#shower-integration

@proddy
Copy link
Contributor Author

proddy commented Aug 29, 2023

Added a new command called boiler/coldshot which can be called via the API and HA

@rene865
Copy link

rene865 commented Aug 30, 2023

can you see what i am doing wrong? I have just started with home assistant and yaml.
EMS-ESP Version 3.7.0-dev.0

i added your example in configuration.yaml, at first I thought the code here was wrong _ems_esp_shower_DATA_duration but what I try it doesn't work.
image
image

but for the new entity the shower duration is not availible
image

@proddy
Copy link
Contributor Author

proddy commented Aug 30, 2023

Sorry! I hadn't made the build yet. Doing it now.

@proddy
Copy link
Contributor Author

proddy commented Aug 30, 2023

Sorry! I hadn't made the build yet. Doing it now.

https://github.com/emsesp/EMS-ESP32/releases/tag/latest

@proddy proddy modified the milestones: v3.7.0, v3.6.0 Aug 31, 2023
@proddy proddy closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@proddy proddy

Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.6.0
Development

No branches or pull requests
2 participants
@proddy @rene865