Pool #104
Merged
Pool #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added some parameters to telegram 0x48D & 0x48F
…added some parameters to telegram 0x48D & 0x48F
MichaelDvP
reviewed
Sep 2, 2021
MichaelDvP
reviewed
Sep 2, 2021
MichaelDvP
reviewed
Sep 2, 2021
proddy
reviewed
Sep 2, 2021
proddy
reviewed
Sep 2, 2021
MichaelDvP
reviewed
Sep 3, 2021
|
ok to merge @MichaelDvP ? |
|
Yes, ok |
|
Yes, Please do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes more work on the pool values coming from MP 100, and some new values on telegram 048D & 048F.
also fixed issue with having 2 of the same product_id, by checking device_type before updating (see #103 )
Added device_id:
{240, DeviceType::CONTROLLER, F("Rego 3000"), DeviceFlags::EMS_DEVICE_FLAG_NONE}, // 0x09,{172, DeviceType::THERMOSTAT, F("IVT Rego 2000/3000"), DeviceFlags::EMS_DEVICE_FLAG_RC300}, // 0x10&{204, DeviceType::MIXER, F("MP100"), DeviceFlags::EMS_DEVICE_FLAG_MP},Added "IVT" as Brand.