Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix revert auto mode -> the mode is hardcoded for the thermostat_ha_cmd #183 #194

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

kpschaper
Copy link
Contributor

@proddy

Not sure if this is the best solution, always pass AUTO mode and determine inside the function if the mode is actual set to AUTO?

set_temperature(f, HeatingCircuit::Mode::AUTO, hc_num);

@proddy
Copy link
Contributor

proddy commented Nov 14, 2021

that is what it does now. The thermostat component in HA is very simple and stupid. It doesn't handle all the modes you can have in thermostats (like temp, summer, comfort, eco, holiday, design etc etc) so I just default it to AUTO when a temperature is changed in HA

@kpschaper
Copy link
Contributor Author

Ah I get it now, it's just the most convenient way to map from HA modes to thermostat specific modes

@proddy
Copy link
Contributor

proddy commented Nov 14, 2021

exactly. Probably the best method is to use whatever the current Thermostat mode is and adjust that setpoint temperature. There's probably a good reason why we don't do it that way. I can't remember. No one has complained so I guess it just works !

What do you want to do with this PR - merge it?

@kpschaper
Copy link
Contributor Author

I think it has to do with the fact that some thermostats have a mode and mode_type.

Yes, please merge this PR and leave it like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants