Skip to content

Commit

Permalink
changed ion-modal settings as per the doc
Browse files Browse the repository at this point in the history
  • Loading branch information
emtiajium committed May 29, 2024
1 parent 9937e66 commit 34c32e6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
11 changes: 9 additions & 2 deletions src/views/vocab-read/Settings.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
<template>
<ion-modal :is-open="isSettingsPopoverOpened" @didDismiss="closeSettingsPopover" id="settings-modal">
<ion-modal
:is-open="isModalOpened"
@didDismiss="
closeSettingsPopover();
isModalOpened = false;
"
id="settings-modal"
>
<ion-content class="settings-container">
<ion-list-header class="header-container">
<ion-card-title class="title"> Settings </ion-card-title>
Expand Down Expand Up @@ -123,6 +130,7 @@ export default defineComponent({
},
data() {
return {
isModalOpened: true,
faTimesCircle,
sortingOptions: {
createdAt_DESC: 'Date created (newest first)',
Expand All @@ -147,7 +155,6 @@ export default defineComponent({
};
},
props: [
'isSettingsPopoverOpened',
'selectedSort',
'closeSettingsPopover',
'onChangeSort',
Expand Down
1 change: 0 additions & 1 deletion src/views/vocab-read/VocabularyList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@

<settings
v-if="isSettingsPopoverOpened"
:is-settings-popover-opened="isSettingsPopoverOpened"
:selected-sort="selectedSort"
:close-settings-popover="closeSettingsPopover"
:apply-settings="applySettings"
Expand Down

0 comments on commit 34c32e6

Please sign in to comment.