Use loose mode on Babel stage-0 plugins #146
Conversation
Specifically needed for the stage-3 plugin for class properties to fix support for mobx and potentially other 3rd party software.
| @@ -22,7 +22,7 @@ module.exports = { | |||
| modules: false | |||
| } | |||
| ], | |||
| '@babel/preset-stage-0', | |||
| ['@babel/preset-stage-0', {loose: true}], | |||
There was a problem hiding this comment.
I'm not sure it's a good idea to go loose on all of the stage 0 presets. It's not recommended to use loose, though it will produce faster code... Can we be more targeted? It seems we only need loose class properties. See mobxjs/mobx#1352 regarding some babel 7 issues. Is Mobx support more important than keeping close to the standard?
There was a problem hiding this comment.
For the webpack 4 work we are specific and only target the class properties plugin (as presets are gone then). Unless we want larger scale changes in cli, we can take this change as a temporary fix until webpack 4 is merged, or wait until the webpack 4 pr goes in. Moreso upto you guys since it only affects mobx for us so far.
|
closing out - @JayCanuck says this PR is no longer needed |
Specifically needed for the stage-3 plugin for class properties to fix support for mobx and potentially other 3rd party software. Fixes the issue observed at enactjs/agate-apps#45 (comment)
Enact-DCO-1.0-Signed-off-by: Jason Robitaille jason.robitaille@lge.com