Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENYO-4653: Abnormal behaviour with 'serve' #96

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Conversation

JayCanuck
Copy link
Member

Use a local fork of extract-text-webpack plugin with a webpack 3.x compatibility patch applied until webpack-contrib/extract-text-webpack-plugin#579 is fixed upstream.

Use a local fork of extract-text-webpack plugin with a webpack 3.x compatibility patch applied until webpack-contrib/extract-text-webpack-plugin#579 is fixed upstream.
@aarontam
Copy link
Contributor

Is there value in creating this fork in a separate location, to decouple it from enact-dev?

@JayCanuck
Copy link
Member Author

Not really. It's a temporary solution and I'd rather not create a separate repo (and have to deal with npm management of said codebase), and this minimizes any lasting impact as we transition back to upstream in the near future.

Copy link
Contributor

@aarontam aarontam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@webOS101 webOS101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@webOS101 webOS101 merged commit 16be5f6 into develop Sep 13, 2017
@webOS101 webOS101 deleted the feature/ENYO-4653 branch September 13, 2017 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants