Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: fixed fs mock #267

Merged
merged 3 commits into from
Mar 15, 2017
Merged

Tests: fixed fs mock #267

merged 3 commits into from
Mar 15, 2017

Conversation

miripiruni
Copy link
Member

@miripiruni miripiruni commented Mar 14, 2017

Starting from bem-xjst v8.6.1 require('bem-xjst').bemhtml doesn’t contain all source code (as string) in private field. When BEMHTML.generate() execute we require bundle.js from FS.

Now: require from FS

Before v8.6.1: source definition and source usage.

@@ -301,6 +301,9 @@ function build(templates, options) {
});
}

var bemhtmlPath = './node_modules/bem-xjst/lib/bemhtml/bundle.js'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment, please

@@ -213,6 +213,9 @@ function build(templates, options) {
});
}

var bemtreePath = './node_modules/bem-xjst/lib/bemtree/bundle.js'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment, please

@miripiruni miripiruni merged commit 370c8e0 into master Mar 15, 2017
@miripiruni miripiruni deleted the mock-fix branch March 15, 2017 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants