Change multicast address and port #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ported to .NET 8
* Allows default multicast address and port to be used (with empty input) * Better logging on error
|
Pasting my latest comment from #3 here for completeness: I have made changes similar to these and updated the PR. I like what you did as it also allows for the user to use the default multicast address and port if not specified. RE: nullable, it was in the default .csprj created with a |
- remove extra using statements - update tool name - fix spelling mistake in a comment - clarify the range of expected inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could have done this without porting to .NET 8, but I don't have Framework set up on my machine and it is pretty old now. Let me know your thoughts