Pass a dict as data to django-filter #2529
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to filter with multivalue params such as 'in' lookups there are two alternatives:
The second option is a better approach when facing strings. However, by definition QueryDict does only take into account the last param included.
Django-filters expect a dict as data. To be congruent with what is passed in the request we need to transform
query_params
to adict
.As can be seen in the test written, adhoc programming must be done also in django-filter to allow 'in' lookups but that's another issue.
Part of the solution was taken from @leo-the-manic in http://stackoverflow.com/questions/13349573/how-to-change-a-django-querydict-to-python-dict#answer-22100334