Add support for Python 3.13 #9527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.13 introduced docstrings for None: python/cpython#117813 In Python 3.12, this is an empty string: ``` ➜ python3.12 Python 3.12.6 (main, Sep 10 2024, 19:06:17) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> d = None >>> d.__doc__ >>> ``` In Python 3.13, it's no longer empty: ``` ➜ python3.13 Python 3.13.0rc2+ (heads/3.13:660baa1, Sep 10 2024, 18:57:50) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> d = None >>> d.__doc__ 'The type of the None singleton.' >>> ``` Adding a check in the inspector that get the view description out the view function docstring to catch this edge case.
browniebroke
commented
Sep 10, 2024
| @@ -4,6 +4,7 @@ envlist = | |||
| {py310}-{django42,django50,django51,djangomain} | |||
| {py311}-{django42,django50,django51,djangomain} | |||
| {py312}-{django42,django50,django51,djangomain} | |||
| {py313}-{django51,djangomain} | |||
There was a problem hiding this comment.
Python 3.13 will be supported only by Django 5.1 and above: https://forum.djangoproject.com/t/backport-python-3-13-support-in-django-5-0/34671/2
auvipy
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues found
1. Fix view description inspection
Python 3.13 introduced docstrings for the
Nonesingletong: python/cpython#117813In Python 3.12, this is an empty string:
In Python 3.13, it's no longer empty:
The fix: added a check in the inspector that get the view description out the view function docstring to catch this edge case.