Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raising on nullable fields part of UniqueConstraint #9531

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix raising on nullable fields part of UniqueConstraint #9531

wants to merge 5 commits into from

Conversation

browniebroke
Copy link
Contributor

@browniebroke browniebroke commented Sep 11, 2024 •
edited
Loading

Description

Fix #9378

  • Add a few failing tests
  • Fix cause of the problem

auvipy
auvipy reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any progress here?

@browniebroke
Copy link
Contributor Author

any progress here?

Not really, I've dropped the ball a bit on this one. Will try to make some progress...

@browniebroke browniebroke marked this pull request as ready for review October 14, 2024 18:14
@browniebroke
Copy link
Contributor Author

Oh well, that's all passing now... Hopefully that covers the main use case reported in #9378

There is also the other semi-related bug #9358 which is NOT in scope of this PR, I believe it will be fixed by #9360

@SorianoMarmol SorianoMarmol mentioned this pull request Oct 23, 2024
Open
@SorianoMarmol
Copy link

Is a new version expected with this fix and others related like #9360 ? The support for UniqueConstraint is not complete and may cause issues…

@BillSchumacher BillSchumacher mentioned this pull request Oct 29, 2024
Open
pauloxnet
pauloxnet approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy left review comments

@pauloxnet pauloxnet pauloxnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.15 is raising required error on model nullable fields
4 participants
@browniebroke @SorianoMarmol @pauloxnet @auvipy