Improve idle check by code review suggestion

httpcore/_async/connection_pool.py

@@ -238,31 +238,31 @@ def _assign_requests_to_connections(self) -> List[AsyncConnectionInterface]:
         those connections to be handled seperately.
         """
         closing_connections = []
-        idling_count = sum(1 for c in self._connections if c.is_idle())
+        idling_count = 0
 
         # First we handle cleaning up any connections that are closed,
         # have expired their keep-alive, or surplus idle connections.
         for connection in list(self._connections):
             if connection.is_closed():
                 # log: "removing closed connection"
                 self._connections.remove(connection)
-                idling_count -= int(connection.is_idle())
             elif connection.has_expired():
                 # log: "closing expired connection"
                 self._connections.remove(connection)
                 closing_connections.append(connection)
-                idling_count -= int(connection.is_idle())
-            elif (
-                connection.is_idle() and idling_count > self._max_keepalive_connections
-            ):
+            elif connection.is_idle():
+                if idling_count < self._max_keepalive_connections:
+                    idling_count += 1
+                    continue
                 # log: "closing idle connection"
                 self._connections.remove(connection)
                 closing_connections.append(connection)
-                idling_count -= 1
 
         # Assign queued requests to connections.
-        queued_requests = [request for request in self._requests if request.is_queued()]
-        for pool_request in queued_requests:
+        for pool_request in list(self._requests):
+            if not pool_request.is_queued():
+                continue
+
             origin = pool_request.request.url.origin
             available_connections = [
                 connection

httpcore/_sync/connection_pool.py

@@ -238,31 +238,31 @@ def _assign_requests_to_connections(self) -> List[ConnectionInterface]:
         those connections to be handled seperately.
         """
         closing_connections = []
-        idling_count = sum(1 for c in self._connections if c.is_idle())
+        idling_count = 0
 
         # First we handle cleaning up any connections that are closed,
         # have expired their keep-alive, or surplus idle connections.
         for connection in list(self._connections):
             if connection.is_closed():
                 # log: "removing closed connection"
                 self._connections.remove(connection)
-                idling_count -= int(connection.is_idle())
             elif connection.has_expired():
                 # log: "closing expired connection"
                 self._connections.remove(connection)
                 closing_connections.append(connection)
-                idling_count -= int(connection.is_idle())
-            elif (
-                connection.is_idle() and idling_count > self._max_keepalive_connections
-            ):
+            elif connection.is_idle():
+                if idling_count < self._max_keepalive_connections:
+                    idling_count += 1
+                    continue
                 # log: "closing idle connection"
                 self._connections.remove(connection)
                 closing_connections.append(connection)
-                idling_count -= 1
 
         # Assign queued requests to connections.
-        queued_requests = [request for request in self._requests if request.is_queued()]
-        for pool_request in queued_requests:
+        for pool_request in list(self._requests):
+            if not pool_request.is_queued():
+                continue
+
             origin = pool_request.request.url.origin
             available_connections = [
                 connection