Fix server disconnect behaviour. #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
changed the title
|
We've also still got some behaviour we can improve on this, around raising the error on multiple streams. (And a related issue about better handling connection-wide HTTP/2 error conditions.) But let's treat those as follow-ups. |
tomchristie
changed the title
tomchristie
changed the title
This was referenced Aug 19, 2020
Merged
florimondmanca
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #159 but narrowing things down a bit.
Fixes an issue in HTTP/1.1 when the server does not include the
Content-Lengthor setTransfer-Encoding: chunkedbut instead uses a server disconnect to signal the end of the response body.If the server disconnects under HTTP/2 then raise an appropriate error.