Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .arequest for the async version of the API. #189

Merged
merged 5 commits into from
Sep 22, 2020
Merged

Use .arequest for the async version of the API. #189

merged 5 commits into from
Sep 22, 2020

Conversation

tomchristie
Copy link
Member

In order to support both sync and async styles on a single implementation class, let's move the async request method into a different namespace.

See encode/httpx#1274

@tomchristie tomchristie mentioned this pull request Sep 21, 2020
Merged
florimondmanca
florimondmanca approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant yup, just want to confirm that this is an initial step towards eventually having a single httpcore.HTTPTransport interface with both .request() and .arequest() on it?

@tomchristie
Copy link
Member Author

Yeah, although more likely httpx.HTTPTransport.

@tomchristie tomchristie merged commit 06d0e77 into master Sep 22, 2020
@tomchristie tomchristie deleted the arequest branch September 22, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomchristie @florimondmanca