-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly wrap asyncio connect errors #235
Properly wrap asyncio connect errors #235
Conversation
118ec02
to
b74beea
Compare
If we need an ordered dict, why not use |
You are right. I forgot that dicts are not ordered by default in 'python3.6' |
819d861
to
60ae602
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The fix seems legit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more thoughts…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do appreciate the extra E2E test here, but to be honest this is a fairly big change footprint — so for the record, I would be very much okay with us merging just the fix in _backends
.
@florimondmanca you are right. I removed all the test code, since it was a bit flaky |
60ae602
to
7836199
Compare
@cdeler Thanks for the update!
So, do we still need to keep the change to the |
@florimondmanca I'd extract it into separate PR with the test (moreover I can be wrong) |
@florimondmanca I added another PR with the Working on this PR I didn't find another tests verified timeouts on I/O routines |
@cdeler Thanks. I retitled this PR according to what this seems to be doing. :-) |
Closes encode/httpx#1387
Fixed the problem with
asyncio
backend, when it incorrectly handles connection timeouts.