Raise ConnectionNotAvailable instead of RemoteProtocolError on request with terminated HTTP/2 connections
#683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
May 11, 2023
|
If I was going to tackle this I would probably start with just the failing test case(s).
|
…quest with terminated HTTP/2 connections
zanieb
commented
May 12, 2023
Comment on lines
+148
to
+153
| if isinstance( | ||
| self._connection_error_event, h2.events.ConnectionTerminated | ||
| ): | ||
| raise ConnectionNotAvailable(self._connection_error_event) | ||
| else: | ||
| raise RemoteProtocolError(self._connection_error_event) |
There was a problem hiding this comment.
I don't love this repeated isinstance check. We could move it into a utility or just always treat _connection_error_event as ConnectionNotAvailable instead of a protocol error.
|
Failing coverage checks now. I didn't add a test at the connection pool level yet. There are not HTTP/2 examples there, but it doesn't seem hard to add a mock stream as you suggested. Feel free to push changes. |
|
I've added issue #730 so that we're tracking this neatly. |
|
Thanks! Now superseeded by #733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #679 (comment)
Attempts to improve handling of HTTP/2 behavior when connections are terminated.
Refs #730