-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy mode for http proxies #734
base: master
Are you sure you want to change the base?
Conversation
current implementation is modified and upgraded of first option discussed in #703 (reply in thread). class ProxyMode(enum.IntFlag):
HTTPS_FORWARD = 1
HTTP_TUNNEL = 2
def HTTPProxy(
...
mode: Optional[ProxyMode] = None,
): ... EDIT: Now I think, this would be better option (using one param instead of two), going for replace it. |
We should probably wait for #714, then open the issue, and only then go through this for further clarity. |
I didn't understand. Will #714 create any blocker for this PR or vice versa? |
I've started an issue for this PR. |
Let's change the title of this PR to something like "Add force-tunneling and force-forwarding support for proxies." |
Really I'd prefer that we work through design discussions first before starting on the pull request, but...
|
Is it possible to include in #768? |
So...
|
Example
|
Co-authored-by: Tom Christie <tom@tomchristie.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #735
Refs: #703 #716
ProxyMode.FORWARD