Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses an issue where connecting to a WebSocket server using the "wss" scheme with TLS connection is not possible. (I have not created a discussion, but since it is a small bug fix, I have created a pull request 🙏)
The problem lies in the condition that enables the SSL context, which currently only allows the "https" scheme. This pull request adds the "wss" scheme to the conditions for enabling the SSL context.
Real-world reproduction code: (
"echo.websocket.events"
is a publicly available WebSocket echo server)Output:
Tests
"connection.start_tls.{started,complete}"
is missing due to the absence of the "wss" scheme in the conditions for enabling the SSL context.Checklist