Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test showing that slow, overlapping requests back each other up in HTTP/2. #948

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nmlorg
Copy link

@nmlorg nmlorg commented Aug 29, 2024

Summary

Quick proof of concept related to encode/httpx#3278 (and possibly #778).

As committed:

$ pytest tests/*/test_http2.py
⋮
tests/_async/test_http2.py ....................F
tests/_sync/test_http2.py ..........F
⋮
>       assert fetches == [1.0] * 5
E       assert [1.4, 1.4, 1.2, 1.8, 1.0] == [1.0, 1.0, 1.0, 1.0, 1.0]

With my work in progress:

$ pytest tests/_sync/test_http2.py
⋮
tests/_sync/test_http2.py ...........

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

…covered by testing.

The accept timeout never triggers during test_http2.py because handle() blocks for the lifetime of the TCP connection. (We could actually move the loop entirely into __main__ and have run() just call accept()/handle() once.)

See https://github.com/encode/httpcore/actions/runs/10620523808/job/29440480372?pr=948.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant