Support QueryParams(None) (#1060)

encode · Jul 16, 2020 · ff93a01 · ff93a01
1 parent ccd4711
commit ff93a01
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/httpx/_client.py b/httpx/_client.py
@@ -73,9 +73,6 @@ def __init__(
         else:
             self.base_url = URL(base_url)
 
-        if params is None:
-            params = {}
-
         self.auth = auth
         self._params = QueryParams(params)
         self._headers = Headers(headers)

diff --git a/httpx/_models.py b/httpx/_models.py
@@ -287,7 +287,7 @@ def __init__(self, *args: QueryParamTypes, **kwargs: typing.Any) -> None:
         value = args[0] if args else kwargs
 
         items: typing.Sequence[typing.Tuple[str, PrimitiveData]]
-        if isinstance(value, str):
+        if value is None or isinstance(value, str):
             items = parse_qsl(value)
         elif isinstance(value, QueryParams):
             items = value.multi_items()

diff --git a/httpx/_types.py b/httpx/_types.py
@@ -34,6 +34,7 @@
     Mapping[str, Union[PrimitiveData, Sequence[PrimitiveData]]],
     List[Tuple[str, PrimitiveData]],
     str,
+    None,
 ]
 
 HeaderTypes = Union[

diff --git a/tests/models/test_queryparams.py b/tests/models/test_queryparams.py
@@ -44,6 +44,9 @@ def test_queryparams(source):
 
 
 def test_queryparam_types():
+    q = QueryParams(None)
+    assert str(q) == ""
+
     q = QueryParams({"a": True})
     assert str(q) == "a=true"