-
-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public API tightening #1066
Comments
Dropping the milestone on this from 0.14 to 1.0, since the remaining items here are pretty minor, but we should still track them. |
cdeler
added a commit
to cdeler/httpx
that referenced
this issue
Aug 6, 2020
cdeler
added a commit
to cdeler/httpx
that referenced
this issue
Aug 6, 2020
cdeler
added a commit
to cdeler/httpx
that referenced
this issue
Aug 6, 2020
cdeler
added a commit
to cdeler/httpx
that referenced
this issue
Aug 6, 2020
cdeler
added a commit
to cdeler/httpx
that referenced
this issue
Aug 6, 2020
tomchristie
pushed a commit
that referenced
this issue
Aug 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following on from #1065
There's a few attributes that are set in
BaseClient.__init__
that look like contenders here for moving into the private API space. Here's what's remaining there...self.base_url
- Potentially modify this to a property setter / getter style, but not 100% obvious?self.auth
- Potentially modify this to a property setter / getter style, but not 100% obvious? - See AddClient.auth
setter #1185self.timeout
- Looks like it should definitely move to a property getter / setter style, as per params/headers/cookies.self.max_redirects
- I think this one is okay as a public attribute, since it's just a plain int.self.trust_env
- Setting this after__init__
isn't really valid (eg. the transport is already initialized) so we could move it to a read-only property? See client.trust_env becomes read-only #1112self.netrc
- Ought to be private. See client.netrc should be private #1071The text was updated successfully, but these errors were encountered: