Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public API tightening #1066

Closed
5 of 6 tasks
tomchristie opened this issue Jul 17, 2020 · 1 comment · Fixed by #1185
Closed
5 of 6 tasks

Public API tightening #1066

tomchristie opened this issue Jul 17, 2020 · 1 comment · Fixed by #1185
Labels
refactor Issues and PRs related to code refactoring
Milestone

Comments

@tomchristie
Copy link
Member

tomchristie commented Jul 17, 2020

Following on from #1065

There's a few attributes that are set in BaseClient.__init__ that look like contenders here for moving into the private API space. Here's what's remaining there...

  • self.base_url - Potentially modify this to a property setter / getter style, but not 100% obvious?
  • self.auth - Potentially modify this to a property setter / getter style, but not 100% obvious? - See Add Client.auth setter #1185
  • self.timeout - Looks like it should definitely move to a property getter / setter style, as per params/headers/cookies.
  • self.max_redirects - I think this one is okay as a public attribute, since it's just a plain int.
  • self.trust_env - Setting this after __init__ isn't really valid (eg. the transport is already initialized) so we could move it to a read-only property? See client.trust_env becomes read-only #1112
  • self.netrc - Ought to be private. See client.netrc should be private #1071
@florimondmanca florimondmanca added the refactor Issues and PRs related to code refactoring label Jul 17, 2020
@tomchristie tomchristie added this to the v0.14 milestone Jul 30, 2020
@tomchristie tomchristie modified the milestones: v0.14, v1.0 Aug 2, 2020
@tomchristie
Copy link
Member Author

Dropping the milestone on this from 0.14 to 1.0, since the remaining items here are pretty minor, but we should still track them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues and PRs related to code refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants