-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Sequence[Tuple[str, str]]
type when setting cookies.
#1209
Comments
We'd want to adjust the Line 1045 in 15c1e42
And adjust the type signature... Line 48 in 15c1e42
Plus add a test case for it in here... https://github.com/encode/httpx/blob/master/tests/models/test_cookies.py cookies = httpx.Cookies([("key1", "value1"), ("key2", "value2")])
# followed by some appropriate assertions, similar to those in `test_cookies`. Ideally do this in two commits - first add the (failing) test case, and then add the fixes. |
Closed via #1211 |
For consistency, we should support styles like:
cookies=[('name', 'value')]
.We allow either dicts or lists-of-tuples for each of
data
,files
,params
&headers
, so it makes sense for us to do it here too.The text was updated successfully, but these errors were encountered: