Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make urllib3 optional. #965

Closed
tomchristie opened this issue May 21, 2020 · 3 comments · Fixed by #969
Closed

Make urllib3 optional. #965

tomchristie opened this issue May 21, 2020 · 3 comments · Fixed by #969
Milestone

Comments

@tomchristie
Copy link
Member

Follow up to #963.

Let's ensure that the urllib3 dependency is optional.

  • Make sure we don't have it anymore in setup.py.
  • Make sure it's listed as optional in the REAEDME/homepage.
  • Make sure that the urllib3.py module passes gracefully on ImportError, and checks the package exists in URLLib3Transport.__init__().
@tomchristie tomchristie added this to the v0.13 milestone May 21, 2020
@yeraydiazdiaz
Copy link
Contributor

The last point is already covered, unless you have a different implementation in mind?

@tomchristie
Copy link
Member Author

Ah fantastic!

@tomchristie
Copy link
Member Author

tomchristie commented May 21, 2020

Have also confirmed that it's not in setup.py, so all we have is...

  • Docs tweak in the advanced section, noting to make sure urllib3 is installed.
  • In README.md and doc/index.md update the dependencies listing. (I guess move urllib3 to just above brotlipy as the other optional, and have httpcore with h11, h2 hanging off as subdependancies, like so...

  • httpcore - The default transport implementation for httpx.
    • h11 - HTTP/1.1 support.
    • h2 - HTTP/2 support.
  • certifi - SSL certificates.
  • chardet - Fallback auto-detection for response encoding.
  • hstspreload - determines whether IDNA-encoded host should be only accessed via HTTPS.
  • idna - Internationalized domain name support.
  • rfc3986 - URL parsing & normalization.
  • urllib3 - Support for httpx.URLLib3Transport(). (Optional)
  • brotlipy - Decoding for "brotli" compressed responses. (Optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants